Progress-tracking, jsdoc, require native Promise support, dependency updates #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think (?) its necessary for it to be a property of the Worker and this just makes it a slightly simpler object
Instead of calling setProgress to initialize the progress, and then using updateProgress as a wrapper around it, initialize the values directly in the constructor, and then we only need one function - updateProgress. This helps the type checker know about the .progress property of the workers.
changed test port to 3001 (less common port number)
This is necessary so that plugins can extend the template.
added npm script for docs generation generated docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the Worker kept hanging on pdf generation until I removed the "es6-promise" dependency. I'm not sure if you'll want to merge this change because it would break the library for people who DO need the promise polyfill, but I made some other changes as well that I think are useful.
There's a rough implementation of the progress tracking feature and jsdoc comments for all the functions/methods.
Even if this pull request isn't appropriate as-is due to the promise polyfill issue, I'd love to connect about how I could help with this project if possible!